Skip to content

docs(licensing): fix LicenseTier values, document EvaluateResult, correct runLicenseCheck idempotency#609

Merged
blove merged 3 commits into
mainfrom
claude/fix-licensing-docs
Jun 7, 2026
Merged

docs(licensing): fix LicenseTier values, document EvaluateResult, correct runLicenseCheck idempotency#609
blove merged 3 commits into
mainfrom
claude/fix-licensing-docs

Conversation

@blove

@blove blove commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Per-lib PR (1 of 3) from the small-libs docs technical review (findings: docs/superpowers/specs/2026-06-06-small-libs-docs-review-findings.md).

  • P0: LicenseTier documented as 'developer-seat' | 'app-deployment' | 'enterprise' → corrected to 'developer_seat' | 'team' | 'enterprise' (license-token.ts:4); also fixed the same wrong union echoed in the introduction.
  • P1: the runLicenseCheck idempotency claim ("return licensed") corrected — it returns the cached status from the first call, not a hard-coded licensed (run-license-check.ts:26-31).
  • P2: documented the exported EvaluateResult type (used in signatures, was missing from the Types section) (evaluate-license.ts:22-26, index.ts:5).
  • P3: standardized env-var access on bracket notation for strict-mode consistency.

Test Plan

  • Each fix verified against its cited source line (controller + implementer).
  • All 4 licensing routes return HTTP 200; no type="note" Callout.

🤖 Generated with Claude Code

…rect runLicenseCheck idempotency

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@blove blove enabled auto-merge (squash) June 7, 2026 03:42
@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadplane Ready Ready Preview, Comment Jun 7, 2026 4:52am

Request Review

blove added a commit that referenced this pull request Jun 7, 2026
…n + findings (#612)

* docs(spec): small-libs (a2ui/licensing/telemetry) docs technical review design

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(plan): small-libs docs technical review implementation plan

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(small-libs): technical review findings report

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(small-libs): mark review findings resolved (PRs #609-611)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@blove blove merged commit 673f95a into main Jun 7, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant